ref(angular): Add transaction source for Angular Router #5382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 tasks
Lms24
changed the title
Lms24
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the transaction name source annotation to the Angular SDK. Since the SDK currently does not parameterize URLs, we only assign
'url'as the transaction name source. We're revisiting parameterization in Angular in a follow up PR.Additionally, the PR adds a two tests to test this change (might be more relevant once we add parameterization). Admittedly, there are better ways to test Angular Services (with the Angular
TestBed) but I got a lot of error messages while trying to get this to work. For the sake of time, the tests for now essentially just treatTraceServiceas a normal class, which is enough to test the transaction source.ref: #5345