Skip to content

fix(remix): Use cjs for main entry point #5352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 4, 2022
Merged

fix(remix): Use cjs for main entry point #5352

merged 1 commit into from
Jul 4, 2022

Conversation

jaykaycodes
Copy link
Contributor

Fixes #5351

Looks like just a typo exporting an esm module under main

@lforst lforst self-requested a review July 4, 2022 07:59
lforst
lforst approved these changes Jul 4, 2022
View reviewed changes
Copy link
Contributor

@lforst lforst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for identifying and fixing this!

@lforst lforst changed the title fix(remix): use cjs for main entry point (#5351) fix(remix): Use cjs for main entry point (#5351) Jul 4, 2022
@lforst lforst changed the title fix(remix): Use cjs for main entry point (#5351) fix(remix): Use cjs for main entry point Jul 4, 2022
@lforst lforst merged commit 259b4f8 into getsentry:master Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@lforst lforst lforst approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[@sentry/remix] - ESM error when importing @sentry/remix

2 participants

@jaykaycodes @lforst