chore(core): Remove circular JSON debugging hacks #5267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
size-limit report 📦
|
lobsterkatie
force-pushed
the
kmclb-clean-up-circular-json-hacks
branch
from
2e123b5 to
3733de3
Compare
lobsterkatie
force-pushed
the
kmclb-clean-up-circular-json-hacks
branch
from
3733de3 to
d11472d
Compare
AbhiPrasad
approved these changes
Jun 16, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #4425 and #4574, various hacks were added to the SDK in aid of debugging #2809. Now that that issue is closed, they (and the clean-up code in tests which was there to compensate for them) can come out.