Skip to content

fix(node): Only set contexts runtime if not set. #5226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix(node): Only set contexts runtime if not set. #5226

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/node/src/client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ export class NodeClient extends BaseClient<NodeClientOptions> {
event.platform = event.platform || 'node';
event.contexts = {
...event.contexts,
runtime: {
runtime: event.contexts?.runtime || {
name: 'node',
version: global.process.version,
},
Expand Down
18 changes: 18 additions & 0 deletions packages/node/test/client.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,6 +216,24 @@ describe('NodeClient', () => {
});
});

test('does not add runtime context to event if already defined on event', () => {
const options = getDefaultNodeClientOptions({ dsn: PUBLIC_DSN });
client = new NodeClient(options);

const event: Event = {
contexts: {
runtime: {
name: 'Electron',
version: '19.0.0',
},
},
};
const hint: EventHint = {};
(client as any)._prepareEvent(event, hint);

expect(event.contexts?.runtime).toEqual(event.contexts?.runtime);
});

test('adds server name to event when value passed in options', () => {
const options = getDefaultNodeClientOptions({ dsn: PUBLIC_DSN, serverName: 'foo' });
client = new NodeClient(options);
Expand Down