ref(node): Compression support for node http transport #5139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
reviewed
May 19, 2022
timfish
force-pushed
the
feat/node-http-compression
branch
from
2dba052 to
ee433ee
Compare
|
Tests added. I also moved the |
timfish
force-pushed
the
feat/node-http-compression
branch
from
ee433ee to
f9c5484
Compare
timfish
force-pushed
the
feat/node-http-compression
branch
from
f9c5484 to
8b1a761
Compare
AbhiPrasad
approved these changes
May 31, 2022
|
I would hold off on merging this one for a moment. I've found a strange issue with some of the Electron tests throwing It looks like that error is suppressed in these tests in the server here but everything decompresses fine after and is valid so I'm a little confused over what causes it and what the implications will be when these hit Relay. |
|
This can now be merged. The test failures for Electron were caused by a bug in the transport! |
lobsterkatie
pushed a commit
that referenced
this pull request
Jun 4, 2022
lobsterkatie
added a commit
that referenced
this pull request
Jun 7, 2022
Note: This is an exact duplicate of #5139 and #5203, both originally by @timfish, which accidentally got merged into the 7.x branch rather than master. #5139: This is mostly stolen straight from the [Electron transport](https://github.com/getsentry/sentry-electron/blob/master/src/main/transports/electron-net.ts). This will help with attachments! #5203: #5139 introduced a subtle bug where `options.headers` was modified which causes headers to leak between requests. This means requests after a compressed request will be incorrectly marked with `content-encoding: gzip`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly stolen straight from the Electron transport.
This will help with attachments!