chore(dev): Clean up main tsconfigs #5114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
size-limit report 📦
|
Lms24
approved these changes
May 17, 2022
AbhiPrasad
pushed a commit
that referenced
this pull request
May 30, 2022
This does some clean up work on our two main tsconfig files, in `@sentry/typescript` and at the root level of our repo. Included changes: - Removed `pretty` - what we had is the default - Removed `noImplicitAny` and `noImplicitThis` - implied by `strict: true` - Turned off emitting types files, as we now do this separately - Moved `noErrorTruncation` up to the typescript package, so that anyone (is there anyone besides us?) using it gets the benefit of actually being able to see full errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does some clean up work on our two main tsconfig files, in
@sentry/typescriptand at the root level of our repo. Included changes:- Removed
pretty- what we had is the default- Removed
noImplicitAnyandnoImplicitThis- implied bystrict: true- Turned off emitting types files, as we now do this separately
- Moved
noErrorTruncationup to the typescript package, so that anyone (is there anyone besides us?) using it gets the benefit of actually being able to see full errors