Skip to content

ref(serverless): Correctly exit on failed version extraction during build #5101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2022
Merged

ref(serverless): Correctly exit on failed version extraction during build #5101

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ jobs:
run: |
echo "Saving SDK_VERSION for later"
cat packages/core/src/version.ts | awk -F"'" '{print $2}' > dist-serverless/version
[ -z $(cat dist-serverless/version) ] && echo "Version extraction failed" && exit 1
[ ! -z $(cat dist-serverless/version) ] && echo SDK_VERSION=$(cat dist-serverless/version) || (echo "Version extraction failed" && exit 1)

outputs:
# this needs to be passed on, because the `needs` context only looks at direct ancestors (so steps which depend on
Expand Down