fix(types): Make @sentry/types a runtime dependency in gatsby and nextjs
#5086
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
size-limit report 📦
|
lforst
approved these changes
May 12, 2022
lobsterkatie
deleted the
kmclb-make-sentry-types-runtime-dep-gatsby-nextjs
branch
AbhiPrasad
pushed a commit
that referenced
this pull request
May 30, 2022
…extjs (#5086) In order that it be installed with the SDK, we make the types package a runtime/regular dependency of all of our other packages, so it's there for anyone using the SDK in a TS app. In the gatsby and nextjs packages, though, it's listed as a dev dependency, and therefore won't be installed. This corrects that by moving it to be a regular dependency in both packages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order that it be installed with the SDK, we make the types package a runtime/regular dependency of all of our other packages, so it's there for anyone using the SDK in a TS app. In the gatsby and nextjs packages, though, it's listed as a dev dependency, and therefore won't be installed. This corrects that by moving it to be a regular dependency in both packages.