chore(dev): Remove redundant prepublishOnly build step in CI
#5083
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lobsterkatie
changed the title
prepublish build step in CIprepublishOnly build step in CI
AbhiPrasad
approved these changes
May 11, 2022
Contributor
size-limit report 📦
|
AbhiPrasad
pushed a commit
that referenced
this pull request
May 30, 2022
Based both on the description in the comment above it and the restrictions on when it is supposed to run, it appears that the `prepublishOnly` step of the `Build` job is meant to do the same thing as the `pack` step of the `Upload Artifacts` job. "Meant" is the operative word, however, because in reality, it doesn't actually do anything - though it calls the repo-level `prepublishOnly` script, which calls the `prepublishOnly` script in every package that has one... no package has one, so it's a no-op. This removes the step and the associated repo-level yarn script, since they seem to have been replaced by the `build:npm` script called in `Upload Artifacts`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based both on the description in the comment above it and the restrictions on when it is supposed to run, it appears that the
prepublishOnlystep of theBuildjob is meant to do the same thing as thepackstep of theUpload Artifactsjob. "Meant" is the operative word, however, because in reality, it doesn't actually do anything - though it calls the repo-levelprepublishOnlyscript, which calls theprepublishOnlyscript in every package that has one... no package has one, so it's a no-op.This removes the step and the associated repo-level yarn script, since they seem to have been replaced by the
build:npmscript called inUpload Artifacts.