Skip to content

feat(dev): Add default Node version for CI jobs #5081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 12, 2022
Merged

feat(dev): Add default Node version for CI jobs #5081

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
012d7ed
add default node version to CI
lobsterkatie May 5, 2022
ac13f97
use node 14 for building
lobsterkatie May 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 18 additions & 3 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ on:
required: false

env:
DEFAULT_NODE_VERSION: '16'

HEAD_COMMIT: ${{ github.event.inputs.commit || github.sha }}

CACHED_DEPENDENCY_PATHS: |
Expand Down Expand Up @@ -45,6 +47,8 @@ jobs:
ref: ${{ env.HEAD_COMMIT }}
- name: Set up Node
uses: actions/setup-node@v1
with:
node-version: ${{ env.DEFAULT_NODE_VERSION }}
# we use a hash of yarn.lock as our cache key, because if it hasn't changed, our dependencies haven't changed,
# so no need to reinstall them
- name: Compute dependency cache key
Expand Down Expand Up @@ -74,6 +78,9 @@ jobs:
ref: ${{ env.HEAD_COMMIT }}
- name: Set up Node
uses: actions/setup-node@v1
with:
# ember won't build under node 16, at least not with the versions of the ember build tools we use
node-version: '14'
- name: Check dependency cache
uses: actions/cache@v2
with:
Expand Down Expand Up @@ -118,7 +125,7 @@ jobs:
- name: Set up Node
uses: actions/setup-node@v1
with:
node-version: '12'
node-version: ${{ env.DEFAULT_NODE_VERSION }}
- name: Check dependency cache
uses: actions/cache@v2
with:
Expand Down Expand Up @@ -149,6 +156,8 @@ jobs:
ref: ${{ env.HEAD_COMMIT }}
- name: Set up Node
uses: actions/setup-node@v1
with:
node-version: ${{ env.DEFAULT_NODE_VERSION }}
- name: Check dependency cache
uses: actions/cache@v2
with:
Expand All @@ -174,6 +183,8 @@ jobs:
ref: ${{ env.HEAD_COMMIT }}
- name: Set up Node
uses: actions/setup-node@v1
with:
node-version: ${{ env.DEFAULT_NODE_VERSION }}
- name: Check dependency cache
uses: actions/cache@v2
with:
Expand All @@ -200,6 +211,8 @@ jobs:
ref: ${{ env.HEAD_COMMIT }}
- name: Set up Node
uses: actions/setup-node@v1
with:
node-version: ${{ env.DEFAULT_NODE_VERSION }}
- name: Check dependency cache
uses: actions/cache@v2
with:
Expand Down Expand Up @@ -367,7 +380,7 @@ jobs:
- name: Set up Node
uses: actions/setup-node@v1
with:
node-version: '16'
node-version: ${{ env.DEFAULT_NODE_VERSION }}
- name: Check dependency cache
uses: actions/cache@v2
with:
Expand Down Expand Up @@ -406,6 +419,8 @@ jobs:
ref: ${{ env.HEAD_COMMIT }}
- name: Set up Node
uses: actions/setup-node@v1
with:
node-version: ${{ env.DEFAULT_NODE_VERSION }}
- name: Check dependency cache
uses: actions/cache@v2
with:
Expand Down Expand Up @@ -438,7 +453,7 @@ jobs:
- name: Set up Node
uses: actions/setup-node@v1
with:
node-version: '16'
node-version: ${{ env.DEFAULT_NODE_VERSION }}
- name: Check dependency cache
uses: actions/cache@v2
with:
Expand Down