ref(build): Improve logging in prepack scripts #5071
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lobsterkatie
force-pushed
the
kmclb-log-error-in-prepack-scripts
branch
from
cd0dab4 to
b3baa15
Compare
size-limit report 📦
|
lforst
approved these changes
May 11, 2022
lobsterkatie
force-pushed
the
kmclb-log-error-in-prepack-scripts
branch
from
b3baa15 to
77a4216
Compare
lobsterkatie
force-pushed
the
kmclb-log-error-in-prepack-scripts
branch
from
77a4216 to
9efb1a1
Compare
AbhiPrasad
pushed a commit
that referenced
this pull request
May 30, 2022
This improves logging in our prepack scripts, primarily by adding newlines and an `ERROR` prefix (to make errors easier to spot in a long stream of logs) and by logging the actual error when something goes wrong (rather than just logging that something is wrong without saying _what_ is wrong).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves logging in our prepack scripts, primarily by adding newlines and an
ERRORprefix (to make errors easier to spot in a long stream of logs) and by logging the actual error when something goes wrong (rather than just logging that something is wrong without saying what is wrong).