Skip to content

log errors regardless of ignoreSentryErrors #5064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

log errors regardless of ignoreSentryErrors #5064

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a7a0598
log errors regardless of `ignoreSentryErrors`
May 10, 2022
09ce867
appease yarn lint
mihasya May 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/serverless/src/awslambda.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,8 +318,10 @@ export function wrapHandler<TEvent, TResult>(
transaction.finish();
hub.popScope();
await flush(options.flushTimeout).catch(e => {
// logging regardless of ignoreSentryErrors makes it possible to detect issues with sentry
// using logs; otherwise, things like oversized payloads fail completely silently.
logger.error(e);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
logger.error(e);
IS_DEBUG_BUILD && logger.error(e);

if (options.ignoreSentryErrors && e instanceof SentryError) {
IS_DEBUG_BUILD && logger.error(e);
return;
}
throw e;
Expand Down