ref(browser): Unify BrowserTransportOptions #5058
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enforce browser transport types by unifying fetch and xhr types into a single `BrowserTransportOptions` interface. This is used as a generic for `ClientOptions<BrowserTransportOptions>`. This cleans up the transport typing, and enables the transportOptions to be typed correctly in init.
Contributor
size-limit report 📦
|
Lms24
approved these changes
May 10, 2022
AbhiPrasad
added a commit
that referenced
this pull request
May 30, 2022
Enforce browser transport types by unifying fetch and xhr types into a single `BrowserTransportOptions` interface. This is used as a generic for `ClientOptions<BrowserTransportOptions>`. This cleans up the transport typing, and enables the transportOptions to be typed correctly in init.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enforce browser transport types by unifying fetch and xhr types into
a single
BrowserTransportOptionsinterface. This is used as a genericfor
ClientOptions<BrowserTransportOptions>.This cleans up the transport typing, and enables the transportOptions to
be typed correctly in init.
Resolves https://getsentry.atlassian.net/browse/WEB-915