chore(build): Remove unnecessary esModuleInterop settings
#4991
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
lobsterkatie
force-pushed
the
kmclb-remove-unnecessary-esmoduleinterop
branch
from
da47980 to
c069bb1
Compare
lforst
approved these changes
Apr 27, 2022
lobsterkatie
force-pushed
the
kmclb-remove-unnecessary-esmoduleinterop
branch
4 times, most recently
from
b13c135 to
7b8363d
Compare
lobsterkatie
force-pushed
the
kmclb-remove-unnecessary-esmoduleinterop
branch
from
7b8363d to
61ea3a9
Compare
AbhiPrasad
pushed a commit
that referenced
this pull request
May 30, 2022
This removes the `esModuleInterop` setting in the following places: - `@sentry/gatsby`, where it's only being used for `@sentry/tracing`, which is an ES module, making the injected helper a pass-through[1]. - `@sentry/vue` and `@sentry/wasm`, where it isn't being used at all (i.e., none of the helpers show up in the built code, meaning there's nothing in the source code that requires (no pun intended!) them). Doing this saves us having to port more config than needed to the new build process. [1] https://github.com/microsoft/tslib/blob/a7129c7bd500ce378ec19234247f3d0b1635e89d/tslib.js#L263
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the
esModuleInteropsetting in the following places:@sentry/gatsby, where it's only being used for@sentry/tracing, which is an ES module, making the injected helper a pass-through.@sentry/vueand@sentry/wasm, where it isn't being used at all (i.e., none of the helpers show up in the built code, meaning there's nothing in the source code that requires (no pun intended!) them).Doing this saves us having to port more config than needed to the new build process.