ref(tests): Suppress unconstructive listener and open handle warnings. #4951
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
|
Can we add some detail (in both the PR description and as a code comment), about why we can't address this at the moment? |
AbhiPrasad
approved these changes
Apr 19, 2022
Lms24
pushed a commit
that referenced
this pull request
Apr 26, 2022
#4951) Removes warnings that we can't address at the moment from Jest logs. 1 - `MaxEventListener` warning is about a potential memory leak when more than 10 event listeners are assigned inside a single thread. As we're running all our integration tests on a single Jest thread, after 10th Sentry initialization, this warning starts polluting logs. Still, it's not great to have unregistered handles around. But we know it's limited to the number of test scenarios here. So IMO this workaround is safe to use for these tests. 2 - `detectOpenHandles` warns about uncleared intervals from `session` tests (where we're hackily replacing flush interval), which we are eventually clearing but can't set a reliable timeout, and we're also using `--forceExit` that does that on exit.
lobsterkatie
pushed a commit
that referenced
this pull request
Apr 26, 2022
#4951) Removes warnings that we can't address at the moment from Jest logs. 1 - `MaxEventListener` warning is about a potential memory leak when more than 10 event listeners are assigned inside a single thread. As we're running all our integration tests on a single Jest thread, after 10th Sentry initialization, this warning starts polluting logs. Still, it's not great to have unregistered handles around. But we know it's limited to the number of test scenarios here. So IMO this workaround is safe to use for these tests. 2 - `detectOpenHandles` warns about uncleared intervals from `session` tests (where we're hackily replacing flush interval), which we are eventually clearing but can't set a reliable timeout, and we're also using `--forceExit` that does that on exit.
lobsterkatie
pushed a commit
that referenced
this pull request
Apr 26, 2022
#4951) Removes warnings that we can't address at the moment from Jest logs. 1 - `MaxEventListener` warning is about a potential memory leak when more than 10 event listeners are assigned inside a single thread. As we're running all our integration tests on a single Jest thread, after 10th Sentry initialization, this warning starts polluting logs. Still, it's not great to have unregistered handles around. But we know it's limited to the number of test scenarios here. So IMO this workaround is safe to use for these tests. 2 - `detectOpenHandles` warns about uncleared intervals from `session` tests (where we're hackily replacing flush interval), which we are eventually clearing but can't set a reliable timeout, and we're also using `--forceExit` that does that on exit.
AbhiPrasad
pushed a commit
that referenced
this pull request
May 30, 2022
#4951) Removes warnings that we can't address at the moment from Jest logs. 1 - `MaxEventListener` warning is about a potential memory leak when more than 10 event listeners are assigned inside a single thread. As we're running all our integration tests on a single Jest thread, after 10th Sentry initialization, this warning starts polluting logs. Still, it's not great to have unregistered handles around. But we know it's limited to the number of test scenarios here. So IMO this workaround is safe to use for these tests. 2 - `detectOpenHandles` warns about uncleared intervals from `session` tests (where we're hackily replacing flush interval), which we are eventually clearing but can't set a reliable timeout, and we're also using `--forceExit` that does that on exit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes warnings that we can't address at the moment from Jest logs.
1 -
MaxEventListenerwarning is about a potential memory leak when more than 10 event listeners are assigned inside a single thread. As we're running all our integration tests on a single Jest thread, after 10th Sentry initialization, this warning starts polluting logs. Still, it's not great to have unregistered handles around. But we know it's limited to the number of test scenarios here. So IMO this workaround is safe to use for these tests.2 -
detectOpenHandleswarns about uncleared intervals fromsessiontests (where we're hackily replacing flush interval), which we are eventually clearing but can't set a reliable timeout, and we're also using--forceExitthat does that on exit. (Also today I learned it should be debugging only)