ref(build): Stop building Vue CDN bundles by default #4839
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neither Vue nor WASM bundles are uploaded as build artifacts or published to our CDN. Therefore it is not necessary to build them by default (i.e. when running `yarn build`). It is still possible to build them by explicitly running `yarn build:bundle(:watch)`.
size-limit report 📦
|
AbhiPrasad
approved these changes
Apr 1, 2022
|
Ah it seems the WASM bundles are needed for the tests? |
|
Right, did not think about that 🤔 That's a good point. So I guess WASM bundles should in fact stay. |
Lms24
changed the title
gonna be taken care of in other PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As recently discovered, neither Vue
nor WASMbundles are uploaded as build artifacts or published to our CDN. Therefore it is not necessary to build them by default (i.e. every time when when runningyarn build).This PR removes bundle creation from the
yarn build(:watch)scripts so that they are not built anymore by default. It is still possible to build them by explicitly by runningyarn build:bundle(:watch).Tiny additional change: added missingbuilddir in theyarn cleancommand for WASM.ref: https://getsentry.atlassian.net/browse/WEB-782