feat(react): Add React 18 as peer dep #4819
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
requested review from
a team,
Lms24 and
lforst
and removed request for
a team
AbhiPrasad
force-pushed
the
abhi-react-18
branch
from
22ac4a7 to
d70f29d
Compare
Contributor
size-limit report 📦
|
MikevPeeren
reviewed
Mar 30, 2022
| @@ -1,4 +1,4 @@ | |||
| import { render } from '@testing-library/react'; | |||
| import { render, act } from '@testing-library/react'; | |||
There was a problem hiding this comment.
You need to change this to { act, render }
- Update tests to test against React 18 - Remove unused `react-test-renderer` dep - Update tests to use `act()`
AbhiPrasad
force-pushed
the
abhi-react-18
branch
from
d0b4ff8 to
b2cb636
Compare
Member
Author
|
Have to use alpha of https://github.com/testing-library/react-testing-library as it's the only one that support React 18: testing-library/react-testing-library#509 (comment). Made myself watch the releases so we can upgrade when they get to a stable version. |
lforst
approved these changes
Mar 31, 2022
Contributor
lforst
left a comment
lforst
left a comment
There was a problem hiding this comment.
LGTM.
(At some point, definitely not now, we should probably change those getBy* returned from render to use screen)
|
v13 is now released from react-testing-library which supports react 18 |
Member
Author
Thanks for letting me know, updated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sentry/reactto include React 18react-test-rendererdepact(): https://reactjs.org/docs/test-utils.html#actFixes #4818
Resolves https://getsentry.atlassian.net/browse/WEB-764