fix(core): Stop mangling _experiments
#4807
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
approved these changes
Mar 28, 2022
Contributor
size-limit report 📦
|
lforst
pushed a commit
that referenced
this pull request
Mar 29, 2022
We hide experimental options behind an `_experiments` flag. This is fine for folks using our npm packages, but for folks using CDN bundles it's a problem, because until now, we've been mangling the property name `_experiments`. (Normally, properties starting with a single underscore are private class methods or fields, the names of both of which it's fine to mangle. We therefore use that as our criterion when telling terser what it may and may not touch, and `_experiments` has been getting swept up by that regex.) This carves out an exception for `_experiments`, so that it is no longer mangled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We hide experimental options behind an
_experimentsflag. This is fine for folks using our npm packages, but for folks using CDN bundles it's a problem, because until now, we've been mangling the property name_experiments. (Normally, properties starting with a single underscore are private class methods or fields, the names of both of which it's fine to mangle. We therefore use that as our criterion when telling terser what it may and may not touch, and_experimentshas been getting swept up by that regex.)This carves out an exception for
_experiments, so that it is no longer mangled.