feat(node): Add new v7 http/s Transports #4781
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lforst
changed the title
lforst
changed the title
AbhiPrasad
reviewed
Mar 25, 2022
Member
AbhiPrasad
left a comment
AbhiPrasad
left a comment
There was a problem hiding this comment.
1st pass while I remember how node http API works lol
Contributor
size-limit report 📦
|
AbhiPrasad
reviewed
Mar 28, 2022
AbhiPrasad
reviewed
Mar 29, 2022
| } | ||
|
|
||
| this._newTransport = makeNewXHRTransport({ | ||
| url, |
Member
There was a problem hiding this comment.
Think it’s a bad rebase, we’ll need to fix this!
Contributor
Author
There was a problem hiding this comment.
sorry, should be resolved now
lforst
force-pushed
the
lforst-node-transports
branch
2 times, most recently
from
8d17a98 to
22b0dba
Compare
added 17 commits
March 29, 2022 13:00
lforst
force-pushed
the
lforst-node-transports
branch
from
22b0dba to
53e0fc0
Compare
AbhiPrasad
approved these changes
Mar 29, 2022
|
|
||
| const SERIALIZED_EVENT_ENVELOPE = serializeEnvelope(EVENT_ENVELOPE); | ||
|
|
||
| const unsafeHttpsModule: HTTPModule = { |
Contributor
Author
There was a problem hiding this comment.
It's unsafe because of the rejectUnauthorized: false option. CodeQL and Sonarlint are also complaining but since this is a test it should be fine.
lforst
force-pushed
the
lforst-node-transports
branch
from
7803fbf to
339062c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds new http and https transports for using the new API discussed in #4660.
Fixes #2549 - we unify http and https in a single transport that differentiates based on the protocol that is used.
Ref: https://getsentry.atlassian.net/browse/WEB-728
Ref: https://getsentry.atlassian.net/browse/WEB-729