feat(vue): Drop vue-router peerDep #4764
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We previously added vue-router as a peer dependency because we rely on it's existence for Vue Performance Monitoring's router instrumentation. We never import directly from this though, we always rely on the user passing it in afterwards. As such, we don't really need to define a peerDep for the vue-router package. We use a similar pattern for the react-router stuff, and it has worked out super well.
AbhiPrasad
requested review from
a team,
lforst and
lobsterkatie
and removed request for
a team
Contributor
size-limit report
|
lforst
approved these changes
Mar 23, 2022
Contributor
lforst
left a comment
lforst
left a comment
There was a problem hiding this comment.
(Let's hope v5 won't change the api 🤞)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4748
We previously added vue-router as a peer dependency because we rely on
it's existence for Vue Performance Monitoring's router instrumentation.
We never import directly from this though, we always rely on the user
passing it in afterwards. As such, we don't really need to define
a peerDep for the vue-router package.
We use a similar pattern for the react-router stuff, and it has worked
out super well.
See: https://docs.sentry.io/platforms/javascript/guides/vue/#vue-3
Resolves https://getsentry.atlassian.net/browse/WEB-739