Skip to content

ref(build): Move build directory to main rollup config #4710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 14, 2022
Merged

ref(build): Move build directory to main rollup config #4710

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/browser/rollup.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ const builds = [];
isAddOn: false,
jsVersion,
licenseTitle: '@sentry/browser',
outputFileBase: `build/bundle${jsVersion === 'es6' ? '.es6' : ''}`,
outputFileBase: `bundle${jsVersion === 'es6' ? '.es6' : ''}`,
});

builds.push(...makeConfigVariants(baseBundleConfig));
Expand Down
4 changes: 3 additions & 1 deletion packages/integrations/rollup.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,9 @@ integrationSourceFiles.forEach(file => {
isAddOn: true,
jsVersion: 'es5',
licenseTitle: '@sentry/integrations',
outputFileBase: `build/${file.replace('.ts', '')}`,
// TODO this doesn't currently need to be a template string, but soon will need to be, so leaving it in that form
// for now
outputFileBase: `${file.replace('.ts', '')}`,
});

// TODO We only need `commonjs` for localforage (used in the offline plugin). Once that's fixed, this can come out.
Expand Down
2 changes: 1 addition & 1 deletion packages/tracing/rollup.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ const builds = [];
isAddOn: false,
jsVersion,
licenseTitle: '@sentry/tracing & @sentry/browser',
outputFileBase: `build/bundle.tracing${jsVersion === 'es6' ? '.es6' : ''}`,
outputFileBase: `bundle.tracing${jsVersion === 'es6' ? '.es6' : ''}`,
});

builds.push(...makeConfigVariants(baseBundleConfig));
Expand Down
2 changes: 1 addition & 1 deletion packages/vue/rollup.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ const baseBundleConfig = makeBaseBundleConfig({
isAddOn: false,
jsVersion: 'es5',
licenseTitle: '@sentry/vue',
outputFileBase: 'build/bundle.vue',
outputFileBase: 'bundle.vue',
});

export default makeConfigVariants(baseBundleConfig);
2 changes: 1 addition & 1 deletion packages/wasm/rollup.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ const baseBundleConfig = makeBaseBundleConfig({
isAddOn: true,
jsVersion: 'es5',
licenseTitle: '@sentry/wasm',
outputFileBase: 'build/wasm',
outputFileBase: 'wasm',
});

export default makeConfigVariants(baseBundleConfig);
2 changes: 1 addition & 1 deletion rollup.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ export function makeBaseBundleConfig(options) {
input,
output: {
// a file extension will be added to this base value when we specify either a minified or non-minified build
file: outputFileBase,
file: `build/${outputFileBase}`,
sourcemap: true,
strict: false,
esModule: false,
Expand Down