Skip to content

feat(tracing): Add ES6 tracing bundle #4674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 4, 2022
Merged

feat(tracing): Add ES6 tracing bundle #4674

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7923d1b
generate es6 tracing bundle
lobsterkatie Mar 2, 2022
2851203
test against es6 tracing bundle in playwright tests
lobsterkatie Mar 2, 2022
830ca68
add es6 tracing bundle to size check
lobsterkatie Mar 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .size-limit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,4 +57,10 @@ module.exports = [
gzip: true,
limit: '100 KB',
},
{
name: '@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified)',
path: 'packages/tracing/build/bundle.tracing.es6.min.js',
gzip: true,
limit: '100 KB',
},
];
5 changes: 2 additions & 3 deletions packages/integration-tests/utils/generatePlugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,8 @@ const BUNDLE_PATHS: Record<string, Record<string, string>> = {
esm: 'esm/index.js',
bundle_es5: 'build/bundle.tracing.js',
bundle_es5_min: 'build/bundle.tracing.min.js',
// `tracing` doesn't have an es6 build yet
bundle_es6: 'build/bundle.tracing.js',
bundle_es6_min: 'build/bundle.tracing.min.js',
bundle_es6: 'build/bundle.tracing.es6.js',
bundle_es6_min: 'build/bundle.tracing.es6.min.js',
},
};

Expand Down
55 changes: 31 additions & 24 deletions packages/tracing/rollup.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,30 +1,37 @@
import { makeBaseBundleConfig, makeLicensePlugin, terserPlugin } from '../../rollup.config';

const builds = [];

const licensePlugin = makeLicensePlugin('@sentry/tracing & @sentry/browser');

const baseBundleConfig = makeBaseBundleConfig({
input: 'src/index.bundle.ts',
isAddOn: false,
jsVersion: 'es5',
outputFileBase: 'build/bundle.tracing',
['es5', 'es6'].forEach(jsVersion => {
const baseBundleConfig = makeBaseBundleConfig({
input: 'src/index.bundle.ts',
isAddOn: false,
jsVersion,
outputFileBase: `build/bundle.tracing${jsVersion === 'es6' ? '.es6' : ''}`,
});

builds.push(
...[
{
...baseBundleConfig,
output: {
...baseBundleConfig.output,
file: `${baseBundleConfig.output.file}.js`,
},
plugins: [...baseBundleConfig.plugins, licensePlugin],
},
{
...baseBundleConfig,
output: {
...baseBundleConfig.output,
file: `${baseBundleConfig.output.file}.min.js`,
},
plugins: [...baseBundleConfig.plugins, terserPlugin, licensePlugin],
},
],
);
});

export default [
// ES5 Browser Tracing Bundle
{
...baseBundleConfig,
output: {
...baseBundleConfig.output,
file: `${baseBundleConfig.output.file}.js`,
},
plugins: [...baseBundleConfig.plugins, licensePlugin],
},
{
...baseBundleConfig,
output: {
...baseBundleConfig.output,
file: `${baseBundleConfig.output.file}.min.js`,
},
plugins: [...baseBundleConfig.plugins, terserPlugin, licensePlugin],
},
];
export default builds;