ref(browser): Make attachStacktrace usage more explicit #4628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
requested review from
a team,
Lms24 and
lobsterkatie
and removed request for
a team
Contributor
size-limit report
|
Member
lobsterkatie
left a comment
lobsterkatie
left a comment
There was a problem hiding this comment.
I think this is a good change!
IMHO we shouldn't do this until the major, though, because we export both eventFromException and eventFromMessage from @sentry/browser, and this changes the signatures of both. And while I get that they're designed for internal use, that doesn't mean people aren't using them. What do you think?
This comment was marked as off-topic.
This comment was marked as off-topic.
Instead of passing down options objects, we instead directly pass down options as appropriate. This makes it very clear how they are being used. Also helps saves on bundle size slightly.
AbhiPrasad
force-pushed
the
abhi-attach-stacktrace
branch
from
14d9846 to
626408d
Compare
lobsterkatie
approved these changes
Mar 1, 2022
AbhiPrasad
added a commit
that referenced
this pull request
Mar 2, 2022
Instead of passing down options objects, we instead directly pass down options as appropriate. This makes it very clear how they are being used. Also helps saves on bundle size slightly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of passing down options objects, we instead directly pass down
options as appropriate. This makes it very clear how they are being
used. Also helps saves on bundle size slightly.