Skip to content

fix(tests): Make CLS web vital test less flaky #4490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 2, 2022
Merged

fix(tests): Make CLS web vital test less flaky #4490

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion packages/integration-tests/suites/tracing/metrics/web-vitals-cls/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,12 @@ sentryTest('should capture a "POOR" CLS vital with its source(s).', async ({ get

expect(eventData.measurements).toBeDefined();
expect(eventData.measurements?.cls?.value).toBeDefined();
expect(eventData.measurements?.cls?.value).toBeCloseTo(0.35);
// This test in particular seems to be flaky, such that the received value is frequently within 0.006 rather than the
// 0.005 that `toBeCloseTo()` requires. While it's true that each test is retried twice if it fails, in the flaky
// cases all three attempts always seem to come up with the exact same slightly-too-far-away number. Rather than ramp
// down `toBeCloseTo()`'s precision (which would make it accept anything between 0.30 and 0.40), we can just do the
// check manually.
expect(eventData.measurements?.cls?.value).toBeGreaterThan(0.34);
expect(eventData.measurements?.cls?.value).toBeLessThan(0.36);
expect(eventData.tags?.['cls.source.1']).toBe('body > div#content > p');
});