chore(tests): Add @utils alias for integration tests.
#4413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Contributor
size-limit report
|
onurtemizkan
force-pushed
the
onur/int-tests-utils-alias
branch
from
ed0a8d8 to
3688e09
Compare
AbhiPrasad
reviewed
Jan 18, 2022
| import { sentryTest } from '../../../../utils/fixtures'; | ||
| import { getSentryRequest } from '../../../../utils/helpers'; | ||
| import { sentryTest } from '@utils/fixtures'; | ||
| import { getSentryRequest } from '@utils/helpers'; |
Member
There was a problem hiding this comment.
tbh I don't see the value in the relative import here, it just makes things more confusing. Any thoughts?
Collaborator
Author
There was a problem hiding this comment.
Yes, actually I thought so. But as we're introducing this alias for subjects, it seemed less confusing to have the same behaviour on the assertions. I'm totally fine with removing aliases for assertions. It requires too much custom configuration anyways.
Collaborator
Author
|
Closing as we decided to keep it simple and avoid using internal aliases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To have a common alias for both assertions and subjects, I added the alias to:
1 - Webpack config (for browser-related utils in
subject.jsfiles)2 - TypeScript config (for assertion utils in
test.tsfiles)3 - ESLint config (To prevent false positives from
import/no-undefinedrule)Also updated
playwrightand@playwright/testto1.18.0-rc1to be able to use aliases defined intsconfig.json: https://github.com/microsoft/playwright/releases/tag/v1.18.0-rc1