fix(nextjs): Inject sentry.x.config.js into pages/_error
#4397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
size-limit report
|
AbhiPrasad
reviewed
Jan 13, 2022
AbhiPrasad
approved these changes
Jan 13, 2022
lobsterkatie
force-pushed
the
kmclb-nextjs-inject-into-_error
branch
from
709ecce to
81313bb
Compare
AbhiPrasad
approved these changes
Jan 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are certain situations where
_erroris loaded before_apphas had a chance to run. In those cases, we miss errors caught in_error, because the SDK has not yet initialized (which currently happens the first time_appruns). This injects the initialization code into_erroras well, to avoid such problems.(In order to not add extra code to the browser bundle, and because this has only shown up as a problem on the server side, for the moment this only does the injection when building the server bundle.)
Fixes #4168.