ref(node): Extract backend logic into eventbuilders #4337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To make the diff easier to read when we remove the backend, I cherry-picked this patch that extracts the `eventFromException` and `eventFromMessage` logic from the backend into their own functions in it's own branch. This patch updates node to behave similarily to browser. There should be no changes required.
sl0thentr0py
approved these changes
Dec 20, 2021
size-limit report
|
vladanpaunovic
approved these changes
Dec 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make the diff easier to read when we remove the backend,
I cherry-picked this patch that extracts the
eventFromExceptionandeventFromMessagelogic from the backend into their own functions init's own branch.
This patch updates node to behave similarily to browser.