Skip to content

feat(utils): Kill some dead code branches in XHR instrumentation #4331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 20, 2021
Merged

feat(utils): Kill some dead code branches in XHR instrumentation #4331

merged 1 commit into from
Dec 20, 2021

Conversation

@mitsuhiko
Copy link
Contributor

@mitsuhiko mitsuhiko commented Dec 17, 2021

I think this can go.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 17, 2021 •
edited
Loading

size-limit report

Path Base Size (7f1fe2d) Current Size Change
@sentry/browser - CDN Bundle (gzipped) 20.35 KB 20.34 KB -0.04% 🔽
@sentry/browser - CDN Bundle (minified) 64.99 KB 64.91 KB -0.12% 🔽
@sentry/browser - Webpack 22.35 KB 22.33 KB -0.11% 🔽
@sentry/browser - Webpack - gzip = false 76.5 KB 76.43 KB -0.11% 🔽
@sentry/react - Webpack 22.38 KB 22.36 KB -0.1% 🔽
@sentry/nextjs Client - Webpack 46.49 KB 46.48 KB -0.03% 🔽
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 28.51 KB 28.5 KB -0.02% 🔽

@mitsuhiko mitsuhiko merged commit ae02a00 into master Dec 20, 2021
@mitsuhiko mitsuhiko deleted the feature/smol-xhr branch December 20, 2021 11:43
@AbhiPrasad AbhiPrasad added this to the Treeshaking / Bundle Size milestone Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Tree shaking / Bundle Size

Development

Successfully merging this pull request may close these issues.

3 participants

@mitsuhiko @AbhiPrasad