Skip to content

ref(react): Stop using parseSemvar #4270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 13, 2021
Merged

ref(react): Stop using parseSemvar #4270

merged 3 commits into from
Dec 13, 2021

Conversation

@AbhiPrasad
Copy link
Member

@AbhiPrasad AbhiPrasad commented Dec 11, 2021 •
edited
Loading

We don't need the bloated method from utils, just make our own. This helps save on bundle size when user's use the ErrorBoundary (which is very common).

We should maybe lint so that parseSemvar is only used in node environments, as including the entire regex is pretty expensive for ungzipped bundle size.

@AbhiPrasad
ref(react): Stop using parseSemvar
d506e46 
We don't need the bloated method from utils, just make our own
@AbhiPrasad AbhiPrasad added this to the Treeshaking / Bundle Size milestone Dec 11, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Dec 11, 2021 •
edited
Loading

size-limit report

Path Base Size (582d678) Current Size Change
@sentry/browser - CDN Bundle (gzipped) 22.45 KB 22.45 KB 0%
@sentry/browser - Webpack 23.29 KB 23.29 KB 0%
@sentry/browser - Webpack - gzip = false 82.73 KB 82.73 KB 0%
@sentry/react - Webpack 23.32 KB 23.32 KB 0%
@sentry/nextjs Client - Webpack 48.07 KB 48.07 KB 0%
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 29.98 KB 29.98 KB -0.01% 🔽

@AbhiPrasad AbhiPrasad marked this pull request as ready for review December 13, 2021 15:04
@AbhiPrasad AbhiPrasad requested review from a team, iker-barriocanal and sl0thentr0py and removed request for a team December 13, 2021 15:04
sl0thentr0py
sl0thentr0py reviewed Dec 13, 2021
View reviewed changes
@AbhiPrasad AbhiPrasad enabled auto-merge (squash) December 13, 2021 17:56
@AbhiPrasad AbhiPrasad merged commit 626102f into master Dec 13, 2021
@AbhiPrasad AbhiPrasad deleted the abhi-react-parseSemvar branch December 13, 2021 18:08
onurtemizkan pushed a commit that referenced this pull request Dec 19, 2021
@AbhiPrasad @onurtemizkan
ref(react): Stop using parseSemvar (#4270)
6d9b7aa 
We don't need the bloated method from utils, just make our own. This helps save on bundle size when user's use the `ErrorBoundary` component (which is very common).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sl0thentr0py sl0thentr0py sl0thentr0py approved these changes

@iker-barriocanal iker-barriocanal Awaiting requested review from iker-barriocanal iker-barriocanal was automatically assigned from getsentry/team-javascript-sdks

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Tree shaking / Bundle Size

Development

Successfully merging this pull request may close these issues.

3 participants

@AbhiPrasad @sl0thentr0py