Skip to content

ref(utils): Extract out Object.prototype.toString into var #4269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

ref(utils): Extract out Object.prototype.toString into var #4269

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 10 additions & 9 deletions packages/utils/src/is.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@
/* eslint-disable @typescript-eslint/explicit-module-boundary-types */

import { Primitive } from '@sentry/types';

const toString: typeof Object.prototype.toString = Object.prototype.toString.bind(Object);

/**
* Checks whether given value's type is one of a few Error or Error-like
* {@link isError}.
Expand All @@ -10,11 +13,9 @@ import { Primitive } from '@sentry/types';
* @returns A boolean representing the result.
*/
export function isError(wat: any): boolean {
switch (Object.prototype.toString.call(wat)) {
switch (toString.call(wat)) {
case '[object Error]':
return true;
case '[object Exception]':
return true;
case '[object DOMException]':
return true;
default:
Expand All @@ -30,7 +31,7 @@ export function isError(wat: any): boolean {
* @returns A boolean representing the result.
*/
export function isErrorEvent(wat: any): boolean {
return Object.prototype.toString.call(wat) === '[object ErrorEvent]';
return toString.call(wat) === '[object ErrorEvent]';
}

/**
Expand All @@ -41,7 +42,7 @@ export function isErrorEvent(wat: any): boolean {
* @returns A boolean representing the result.
*/
export function isDOMError(wat: any): boolean {
return Object.prototype.toString.call(wat) === '[object DOMError]';
return toString.call(wat) === '[object DOMError]';
}

/**
Expand All @@ -52,7 +53,7 @@ export function isDOMError(wat: any): boolean {
* @returns A boolean representing the result.
*/
export function isDOMException(wat: any): boolean {
return Object.prototype.toString.call(wat) === '[object DOMException]';
return toString.call(wat) === '[object DOMException]';
}

/**
Expand All @@ -63,7 +64,7 @@ export function isDOMException(wat: any): boolean {
* @returns A boolean representing the result.
*/
export function isString(wat: any): boolean {
return Object.prototype.toString.call(wat) === '[object String]';
return toString.call(wat) === '[object String]';
}

/**
Expand All @@ -85,7 +86,7 @@ export function isPrimitive(wat: any): wat is Primitive {
* @returns A boolean representing the result.
*/
export function isPlainObject(wat: any): boolean {
return Object.prototype.toString.call(wat) === '[object Object]';
return toString.call(wat) === '[object Object]';
}

/**
Expand Down Expand Up @@ -118,7 +119,7 @@ export function isElement(wat: any): boolean {
* @returns A boolean representing the result.
*/
export function isRegExp(wat: any): boolean {
return Object.prototype.toString.call(wat) === '[object RegExp]';
return toString.call(wat) === '[object RegExp]';
}

/**
Expand Down