ref(browser): Extract global handlers private methods #4265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report
|
|
I broke the integration tests! Nice! |
AbhiPrasad
force-pushed
the
abhi-global-handlers
branch
from
8401e42 to
d0edcd9
Compare
- Move hub and client getters out to a common call and pass them down - Check for integration existence early on - Move private methods into regular functions as they don't use class props
AbhiPrasad
force-pushed
the
abhi-global-handlers
branch
from
5fdfd09 to
793b104
Compare
2 tasks
AbhiPrasad
commented
Dec 13, 2021
| if (installFunc && options[key as GlobalHandlersIntegrationsOptionKeys]) { | ||
| globalHandlerLog(key); | ||
| installFunc(hub, attachStacktrace); | ||
| this._installFunc[key as GlobalHandlersIntegrationsOptionKeys] = undefined; |
There was a problem hiding this comment.
tbh idk why have this guard because addInstrumentationHandler should be sufficient, but keeping it here for now 🤷
mitsuhiko
approved these changes
Dec 14, 2021
onurtemizkan
pushed a commit
that referenced
this pull request
Dec 19, 2021
- Move private methods into regular functions as they don't use class props - Use dynamic dispatch object, `_installFunc` to call install methods on instrumentation - Extract capture exception into common method `function addMechanismAndCapture` - Alias unminified variable names (remove `event.exception.values[0].stacktrace.frames`) - Extract logging into function `function globalHandlerLog` - Introduce function to call `getCurrentHub` and return client options.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move hub and client getters out to a common call and pass them downprops
(pass down hub, client options explicitly)_installFuncto call install methods on instrumentationfunction addMechanismAndCaptureevent.exception.values[0].stacktrace.frames)function globalHandlerLoggetCurrentHuband return client options.