ci: Separate browser integration and build tests #4230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The jobs can run independently, and when we run the integration tests with a test matrix with multiple target browsers, we don't need to re-run the build tests for N browsers (the build test is browser-independent).
rhcarvalho
force-pushed
the
rhcarvalho/separate-browser-build-test
branch
from
92c9cd5 to
12844fa
Compare
rhcarvalho
commented
Dec 3, 2021
| name: Browser Build Tests | ||
| needs: job_build | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 5 |
Contributor
Author
There was a problem hiding this comment.
Using a smaller number than the other jobs because this should not take long, it is just a trivial script.
The GHA default is 360 minutes, which is too much.
rhcarvalho
requested review from
a team,
lobsterkatie and
sl0thentr0py
and removed request for
a team
Contributor
size-limit report
|
onurtemizkan
pushed a commit
that referenced
this pull request
Dec 19, 2021
The jobs can run independently, and when we run the integration tests with a test matrix with multiple target browsers, we don't need to re-run the build tests for N browsers (the build test is browser-independent).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The jobs can run independently, and when we run the integration tests with a test matrix with multiple target browsers, we don't need to re-run the build tests for N browsers (the build test is browser-independent).