Skip to content

fix(ember): Fix span names in tests #4228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 3, 2021
Merged

fix(ember): Fix span names in tests #4228

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
104 changes: 52 additions & 52 deletions packages/ember/tests/acceptance/sentry-performance-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,10 @@ function assertSentryCall(assert, callNumber, options) {
// FIXME: For some reason, the last `afterRender` and `destroy` run queue event are not always called.
// This is not a blocker, but should be investigated and fixed, as this is the expected output.
const lastSpan = event.spans[event.spans.length - 1];
if (lastSpan === 'ember.runloop.afterRender | undefined') {
event.spans.push('ember.runloop.destroy | undefined');
} else if (lastSpan === 'ember.runloop.render | undefined') {
event.spans.push('ember.runloop.afterRender | undefined', 'ember.runloop.destroy | undefined');
if (lastSpan === 'ui.ember.runloop.afterRender | undefined') {
event.spans.push('ui.ember.runloop.destroy | undefined');
} else if (lastSpan === 'ui.ember.runloop.render | undefined') {
event.spans.push('ui.ember.runloop.afterRender | undefined', 'ui.ember.runloop.destroy | undefined');
}

assert.deepEqual(event.spans, options.spans, `Has correct spans`);
Expand All @@ -60,15 +60,15 @@ module('Acceptance | Sentry Transactions', function(hooks) {
assertSentryTransactionCount(assert, 1);
assertSentryCall(assert, 0, {
spans: [
'ember.transition | route:undefined -> route:tracing',
'ember.component.render | component:link-to',
'ember.component.render | component:link-to',
'ember.component.render | component:test-section',
'ember.runloop.actions | undefined',
'ember.runloop.routerTransitions | undefined',
'ember.runloop.render | undefined',
'ember.runloop.afterRender | undefined',
'ember.runloop.destroy | undefined',
'ui.ember.transition | route:undefined -> route:tracing',
'ui.ember.component.render | component:link-to',
'ui.ember.component.render | component:link-to',
'ui.ember.component.render | component:test-section',
'ui.ember.runloop.actions | undefined',
'ui.ember.runloop.routerTransitions | undefined',
'ui.ember.runloop.render | undefined',
'ui.ember.runloop.afterRender | undefined',
'ui.ember.runloop.destroy | undefined',
],
transaction: 'route:tracing',
tags: {
Expand All @@ -87,53 +87,53 @@ module('Acceptance | Sentry Transactions', function(hooks) {
assertSentryTransactionCount(assert, 2);
assertSentryCall(assert, 1, {
spans: [
'ember.transition | route:tracing -> route:slow-loading-route.index',
'ember.component.render | component:link-to',
'ember.component.render | component:link-to',
'ui.ember.transition | route:tracing -> route:slow-loading-route.index',
'ui.ember.component.render | component:link-to',
'ui.ember.component.render | component:link-to',
'ember.route.beforeModel | slow-loading-route',
'ember.runloop.actions | undefined',
'ember.runloop.routerTransitions | undefined',
'ember.runloop.render | undefined',
'ember.runloop.afterRender | undefined',
'ember.runloop.destroy | undefined',
'ui.ember.runloop.actions | undefined',
'ui.ember.runloop.routerTransitions | undefined',
'ui.ember.runloop.render | undefined',
'ui.ember.runloop.afterRender | undefined',
'ui.ember.runloop.destroy | undefined',
'ember.route.model | slow-loading-route',
'ember.runloop.actions | undefined',
'ember.runloop.routerTransitions | undefined',
'ember.runloop.render | undefined',
'ember.runloop.afterRender | undefined',
'ember.runloop.destroy | undefined',
'ui.ember.runloop.actions | undefined',
'ui.ember.runloop.routerTransitions | undefined',
'ui.ember.runloop.render | undefined',
'ui.ember.runloop.afterRender | undefined',
'ui.ember.runloop.destroy | undefined',
'ember.route.afterModel | slow-loading-route',
'ember.runloop.actions | undefined',
'ember.runloop.routerTransitions | undefined',
'ember.component.render | component:link-to',
'ember.component.render | component:link-to',
'ember.runloop.render | undefined',
'ember.runloop.afterRender | undefined',
'ember.runloop.destroy | undefined',
'ui.ember.runloop.actions | undefined',
'ui.ember.runloop.routerTransitions | undefined',
'ui.ember.component.render | component:link-to',
'ui.ember.component.render | component:link-to',
'ui.ember.runloop.render | undefined',
'ui.ember.runloop.afterRender | undefined',
'ui.ember.runloop.destroy | undefined',
'ember.route.beforeModel | slow-loading-route.index',
'ember.runloop.actions | undefined',
'ember.runloop.routerTransitions | undefined',
'ember.runloop.render | undefined',
'ember.runloop.afterRender | undefined',
'ember.runloop.destroy | undefined',
'ui.ember.runloop.actions | undefined',
'ui.ember.runloop.routerTransitions | undefined',
'ui.ember.runloop.render | undefined',
'ui.ember.runloop.afterRender | undefined',
'ui.ember.runloop.destroy | undefined',
'ember.route.model | slow-loading-route.index',
'ember.runloop.actions | undefined',
'ember.runloop.routerTransitions | undefined',
'ember.runloop.render | undefined',
'ember.runloop.afterRender | undefined',
'ember.runloop.destroy | undefined',
'ui.ember.runloop.actions | undefined',
'ui.ember.runloop.routerTransitions | undefined',
'ui.ember.runloop.render | undefined',
'ui.ember.runloop.afterRender | undefined',
'ui.ember.runloop.destroy | undefined',
'ember.route.afterModel | slow-loading-route.index',
'ember.runloop.actions | undefined',
'ui.ember.runloop.actions | undefined',
'ember.route.setupController | slow-loading-route',
'ember.route.setupController | slow-loading-route.index',
'ember.runloop.routerTransitions | undefined',
'ember.component.render | component:link-to',
'ember.component.render | component:link-to',
'ember.component.render | component:slow-loading-list',
'ember.component.render | component:slow-loading-list',
'ember.runloop.render | undefined',
'ember.runloop.afterRender | undefined',
'ember.runloop.destroy | undefined',
'ui.ember.runloop.routerTransitions | undefined',
'ui.ember.component.render | component:link-to',
'ui.ember.component.render | component:link-to',
'ui.ember.component.render | component:slow-loading-list',
'ui.ember.component.render | component:slow-loading-list',
'ui.ember.runloop.render | undefined',
'ui.ember.runloop.afterRender | undefined',
'ui.ember.runloop.destroy | undefined',
],
transaction: 'route:slow-loading-route.index',
durationCheck: duration => duration > SLOW_TRANSITION_WAIT,
Expand Down