ref(tracing): update hasTracingEnabled return value #4225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
commented
Dec 2, 2021
Contributor
size-limit report
|
rhcarvalho
reviewed
Dec 3, 2021
Contributor
rhcarvalho
left a comment
rhcarvalho
left a comment
There was a problem hiding this comment.
This shows how the implementation could be a oneliner...
return options && ('tracesSampleRate' in options || 'tracesSampler' in options);
packages/tracing/test/utils.test.ts
Outdated
| const tracesSampler = () => 1; | ||
| const tracesSampleRate = 1; | ||
| it.each([ | ||
| ['no options', undefined, false], |
Contributor
There was a problem hiding this comment.
Doesn't the output in this one case depend on the return value of getCurrentHub()?
Member
Author
There was a problem hiding this comment.
Yes it depends on getCurrentHub, but there is no client attached to it during the test, so it works as expected.
I agree it could be a one liner, but I didn't change the function to minimize changing behaviour. I can go back and update!
AbhiPrasad
changed the title
AbhiPrasad
force-pushed
the
abhi-has-tracing-enabled-test
branch
from
5417ded to
e4fc16a
Compare
rhcarvalho
approved these changes
Dec 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Experimenting with bundle size that didn't make any progress, but cherry-picked this off that branch.