Skip to content

fix(node): Make http integration spans have http span operation #4224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 3, 2021
Merged

fix(node): Make http integration spans have http span operation #4224

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9732ad8
fix(node): Make http integration spans have http span operation
AbhiPrasad Dec 2, 2021
2d564e6
change to http.client
AbhiPrasad Dec 3, 2021
83d10e2
fix test
AbhiPrasad Dec 3, 2021
4cb59c8
fix nextjs test
AbhiPrasad Dec 3, 2021
3ceef9a
Merge branch 'master' into abhi-node-ops-http
AbhiPrasad Dec 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/nextjs/test/integration/test/server/tracingHttp.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ module.exports = async ({ url: urlBase, argv }) => {
spans: [
{
description: 'GET http://example.com/',
op: 'request',
op: 'http.client',
status: 'ok',
tags: { 'http.status_code': '200' },
},
Expand Down
2 changes: 1 addition & 1 deletion packages/node/src/integrations/http.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ function _createWrappedRequestMethodFactory(
if (parentSpan) {
span = parentSpan.startChild({
description: `${requestOptions.method || 'GET'} ${requestUrl}`,
op: 'request',
op: 'http.client',
});

const sentryTraceHeader = span.toTraceparent();
Expand Down
2 changes: 1 addition & 1 deletion packages/node/test/integrations/http.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ describe('tracing', () => {

// our span is at index 1 because the transaction itself is at index 0
expect(spans[1].description).toEqual('GET http://dogs.are.great/');
expect(spans[1].op).toEqual('request');
expect(spans[1].op).toEqual('http.client');
});

it("doesn't create a span for outgoing sentry requests", () => {
Expand Down