ci: Switch to getsentry/size-limit-action #4211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
size-limit report
|
Member
Author
😎 Thanks @billyvg |
billyvg
approved these changes
Dec 1, 2021
Member
billyvg
left a comment
billyvg
left a comment
There was a problem hiding this comment.
👀 I don't remember what other changes were made in the fork, but just be aware there may have been some column cuts?
Member
Author
|
Yeah we'll run it on a couple of PRs after and see if anything comes up, can always revert/update the fork if needed. |
AbhiPrasad
added a commit
that referenced
this pull request
Dec 2, 2021
onurtemizkan
pushed a commit
that referenced
this pull request
Dec 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we rebuilt all our assets for size-check, leading it to take 7-8 minutes. Switching to Sentry forks helps address this + makes the comparison more robust by leveraging GH artifacts.