Skip to content

Conversation

@lobsterkatie
Copy link
Member

This adds a script to be run after the nextjs app is built when testing an SDK branch on Vercel. More specifically, it

  • moves the command to make the bundle analysis files available on the deployed app from a one-liner in the Vercel project settings to a script (because the code to do that correctly turns out to be a little more complicated than we thought),
  • looks in the correct location for files created by experimental-serverless-trace builds, and
  • only attempts to move the files if they exist.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 11, 2021

size-limit report

Path Size
@sentry/browser - CDN Bundle (gzipped) 22.33 KB (-0.01% 🔽)
@sentry/browser - Webpack 23.31 KB (0%)
@sentry/react - Webpack 23.34 KB (0%)
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 29.79 KB (0%)

@kamilogorek
Copy link
Contributor

Minor path change for consistency. You can also unify all echos to \nYour message\n if you want fewer lines, but I don't mind.

@lobsterkatie
Copy link
Member Author

You can also unify all echos to \nYour message\n if you want fewer lines, but I don't mind.

Oh, man. Wouldn't I like to. I can't tell you how much time* I spent fighting with the shell on Vercel trying to get this to work. I can't remember the details - something about sh vs bash, though that wasn't the only issue - but nothing worked.

* My commit log from that time (related commits highlighted):

image

@lobsterkatie lobsterkatie merged commit 2dbe5d7 into master Oct 12, 2021
@lobsterkatie lobsterkatie deleted the kmclb-nextjs-add-post-build-script-on-vercel branch October 12, 2021 17:10
@kamilogorek
Copy link
Contributor

Sorry, I expected too much from their environment 🥲

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants