feat(browser): Client Report Support #3955
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhcarvalho
reviewed
Sep 3, 2021
rhcarvalho
reviewed
Sep 3, 2021
rhcarvalho
reviewed
Sep 3, 2021
Contributor
size-limit report
|
rhcarvalho
reviewed
Sep 3, 2021
kamilogorek
force-pushed
the
client-report
branch
from
498fa19 to
e5ce2b0
Compare
AbhiPrasad
reviewed
Sep 7, 2021
Member
AbhiPrasad
left a comment
AbhiPrasad
left a comment
There was a problem hiding this comment.
Quick review, will do in more detail after DACI is ✅
Contributor
iker-barriocanal
left a comment
iker-barriocanal
left a comment
There was a problem hiding this comment.
Haven't looked at tests yet.
kamilogorek
force-pushed
the
client-report
branch
2 times, most recently
from
e107443 to
7d924e7
Compare
kamilogorek
changed the title
kamilogorek
force-pushed
the
client-report
branch
6 times, most recently
from
cd5162c to
0e585c2
Compare
AbhiPrasad
approved these changes
Sep 10, 2021
Member
AbhiPrasad
left a comment
AbhiPrasad
left a comment
There was a problem hiding this comment.
Ok nice, I think we are good to go
Contributor
Author
|
We'll cut the beta release from this branch, so I will hold with merging it to master. |
iker-barriocanal
approved these changes
Sep 13, 2021
Contributor
iker-barriocanal
left a comment
iker-barriocanal
left a comment
There was a problem hiding this comment.
LGTM, just minor feedback.
kamilogorek
force-pushed
the
client-report
branch
from
01c3c4f to
b65a83b
Compare
Contributor
|
🚀 |
kamilogorek
force-pushed
the
client-report
branch
2 times, most recently
from
73480d5 to
a7eaf2f
Compare
kamilogorek
force-pushed
the
client-report
branch
from
385caf5 to
a787894
Compare
This was referenced Feb 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for client reports to the Browser SDK. This will cause the SDK to send a report once the tab goes hidden or has been closed and will send it as a separate envelope.
The feature can be turned off via the
sendClientReportsoption which is on by default.Refs:
getsentry/relay#1074
getsentry/sentry-python#1181