Skip to content

Conversation

@luin
Copy link
Contributor

@luin luin commented Aug 17, 2021

When the exceptions are thrown from native code (see To reproduce below), InboundFilters#_getLastValidUrl() returns [native code] instead of a valid URL, causing InboundFilters#_isAllowedUrl() fail.

This PR skips native frames to solve the issue.

Package + Version

@sentry/[email protected]

To reproduce

Visit https://codepen.io/luin/pen/qBmGgwv on Safari. It contains a regexp that Safari doesn't support. The error stack will show on the alert box. Notice that the first frame is [native code].


  • If you've added code that should be tested, please add tests.
  • Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

@luin luin requested a review from kamilogorek as a code owner August 17, 2021 16:00
@kamilogorek kamilogorek merged commit 19ef32c into getsentry:master Aug 18, 2021
@kamilogorek
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants