Skip to content

fix(vue): Make Router.name type optional to match VueRouter #3843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 27, 2021
Merged

fix(vue): Make Router.name type optional to match VueRouter #3843

merged 1 commit into from
Jul 27, 2021

Conversation

@kamilogorek
Copy link
Contributor

@kamilogorek kamilogorek commented Jul 27, 2021

@github-actions
Copy link
Contributor

github-actions bot commented Jul 27, 2021

size-limit report

Path Size
@sentry/browser - CDN Bundle (gzipped) 21.46 KB (+0.01% 🔺)
@sentry/browser - Webpack 22.47 KB (0%)
@sentry/react - Webpack 22.5 KB (0%)
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 28.87 KB (+0.01% 🔺)

@kamilogorek kamilogorek merged commit fd6e641 into master Jul 27, 2021
@kamilogorek kamilogorek deleted the vuerouter-name-type branch July 27, 2021 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

@lobsterkatie lobsterkatie Awaiting requested review from lobsterkatie

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kamilogorek @AbhiPrasad