Skip to content

fix(core): Skip anonymous callbacks while searching frame URLs. #3842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 27, 2021
Merged

fix(core): Skip anonymous callbacks while searching frame URLs. #3842

merged 4 commits into from
Jul 27, 2021

Conversation

@onurtemizkan
Copy link
Collaborator

@onurtemizkan onurtemizkan commented Jul 27, 2021

Fixes: #3800

Ideally, should be tested on different browsers/versions with real stack traces. Ref: #3841

@github-actions
Copy link
Contributor

github-actions bot commented Jul 27, 2021 •
edited
Loading

size-limit report

Path Size
@sentry/browser - CDN Bundle (gzipped) 21.51 KB (+0.23% 🔺)
@sentry/browser - Webpack 22.53 KB (+0.27% 🔺)
@sentry/react - Webpack 22.56 KB (+0.27% 🔺)
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 28.92 KB (+0.16% 🔺)

kamilogorek
kamilogorek suggested changes Jul 27, 2021
View reviewed changes
Copy link
Contributor

@kamilogorek kamilogorek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We always return null from getLastValidUrl anyway, so we can remove the ternary operators there.

@onurtemizkan
Copy link
Collaborator Author

onurtemizkan commented Jul 27, 2021

@kamilogorek, fixed 👍

@onurtemizkan onurtemizkan enabled auto-merge (squash) July 27, 2021 14:10
@onurtemizkan onurtemizkan merged commit 74a0829 into master Jul 27, 2021
@onurtemizkan onurtemizkan deleted the onur/last-valid-frame-url branch July 27, 2021 14:21
@lobsterkatie lobsterkatie mentioned this pull request Jul 27, 2021
Closed
@lobsterkatie lobsterkatie mentioned this pull request Sep 13, 2021
Closed
@amakhrov amakhrov mentioned this pull request Dec 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lobsterkatie lobsterkatie Awaiting requested review from lobsterkatie

1 more reviewer

@kamilogorek kamilogorek kamilogorek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[browser] Handle anonymous callbacks more gracefully when using allowUrls/denyUrls

3 participants

@onurtemizkan @kamilogorek