fix(react): Make Route typing more generic #3809
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DefinitelyTyped/DefinitelyTyped#51355 merging in lead to some more robust type inference for React Router params. This means that for Typescript >= 4.1.5, certain param types break when using the `withSentryRouting` higher order component. To fix this issue, we use a generic instead of a React component type for the wrapped React component. As we have to use this generic instead of a specific React type, we have to use @ts-ignore to make the JSX expressions work with typescript. Fixes #3808
kamilogorek
approved these changes
Jul 15, 2021
Contributor
size-limit report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DefinitelyTyped/DefinitelyTyped#51355 merging in
lead to some more robust type inference for React Router params. This
means that for Typescript >= 4.1.5, certain param types break when using
the
withSentryRoutinghigher order component.To fix this issue, we use a generic instead of a React component type
for the wrapped React component. As we have to use this generic instead
of a specific React type, we have to use @ts-ignore to make the JSX
expressions work with typescript.
Fixes #3808.