Update import path in ember instance-initializer #3785
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiwi-josh
force-pushed
the
fix/ember-performance-import
branch
from
33d29e1 to
23264ba
Compare
…wser) in the the ember instance-initializer, otherwise any existing client that gets created by the app author gets overriden by this one - and loses any app specific BrowserOptions config
kiwi-josh
force-pushed
the
fix/ember-performance-import
branch
from
23264ba to
3045d54
Compare
kamilogorek
approved these changes
Jul 8, 2021
k-fish
requested changes
Jul 8, 2021
Member
k-fish
left a comment
k-fish
left a comment
There was a problem hiding this comment.
Discussed this via discord, there is a better fix for this which I'll put up as a separate PR, closing for now 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Import Sentry from the @sentry/ember package (rather than @sentry/browser) in the the ember instance-initializer, otherwise any existing client that gets created by the app author gets overridden by this one when init is called - and loses any app specific
BrowserOptionsconfig that isn't defined directly in theconfig/environment.js