fix(react): allRoutes cannot triple equal a new array instance #3779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running `===` against a newly instantiated array will always return false. Instead, we should check that `allRoutes` is empty.
kamilogorek
approved these changes
Jul 7, 2021
Contributor
kamilogorek
left a comment
kamilogorek
left a comment
There was a problem hiding this comment.
LGTM code wise cc @AbhiPrasad for logic check.
AbhiPrasad
approved these changes
Jul 7, 2021
Member
AbhiPrasad
left a comment
AbhiPrasad
left a comment
There was a problem hiding this comment.
We should write an eslint rule to guard against this
AbhiPrasad
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running
===against a newly instantiated array will always returnfalse. Instead, we should check that
allRoutesis empty.