Skip to content

fix: Update ExtractedNodeRequestData to include valid query_params for tracesSampler #3715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 6, 2021
Merged

fix: Update ExtractedNodeRequestData to include valid query_params for tracesSampler #3715

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7ac1381
fix: Update ExtractedNodeRequestData to include valid query_params fo…
kamilogorek Jun 21, 2021
db0b24e
Update misc.ts
kamilogorek Jun 21, 2021
05f7516
Merge branch 'master' into tracer-query-params
kamilogorek Jul 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/types/src/misc.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import { QueryParams } from './request';

/**
* Data extracted from an incoming request to a node server
*/
Expand All @@ -16,8 +18,8 @@ export interface ExtractedNodeRequestData {
/** String representing the cookies sent along with the request */
cookies?: { [key: string]: string };

/** The request's query string, without the leading '?' */
query_string?: string;
/** The request's query params */
query_string?: QueryParams;

/** Any data sent in the request's body, as a JSON string */
data?: string;
Expand Down