deps: Update @sentry/webpack-plugin to 1.15.1 in @sentry/nextjs #3708
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
approved these changes
Jun 18, 2021
Contributor
size-limit report
|
lobsterkatie
added
dependencies
Package: nextjs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3702
Context:
getsentry/sentry-webpack-plugin#187
getsentry/sentry-cli#949
TL;DR - Using
silent: truein the @sentry/nextjs webpack plugin config triggered the same option in sentry-cli's, and that made builds hang because the CLI was outputting to a stream which filled up waiting for its data to be consumed, which it never was. Lots more detail in the linkedsentry-webpack-pluginissue above.Once the bug was fixed in
sentry-cli, the webpack plugin needed to be updated to use the fix, and then the nextjs SDK had to be updated to use the new webpack plugin version.