fix(nextjs): Fix return type when injecting sentry code using webpack #3625
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
size-limit report
|
Collaborator
|
This also fixes #3538 |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes a hack which was getting around an async/await problem, wherein what should have been a value was instead a promise. This mismatch prevented next's internal work cleaning up the webpack
entryproperty and forced us to do it instead. (Specifically,nextmerges themain.jsandmainentries, before deleting themain.jsentry.)In addition to being a little ugly, this hack introduced a bug, because we deleted, but didn't merge. This gets around that problem by fixing the return type so that
nextcan correctly access the value and do the merging and deleting itself.Fixes #3538
Fixes #3591