fix(sessions): Correctly compute session duration #3616
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
size-limit report
|
rhcarvalho
suggested changes
May 28, 2021
Contributor
rhcarvalho
left a comment
rhcarvalho
left a comment
There was a problem hiding this comment.
@AbhiPrasad thanks for taking a crack at this and shipping quick! We're definitely missing tests here to cover 1) the original bug 2) the undesired changes in types for the wire format.
Member
Author
|
Thanks for your detailed review @rhcarvalho, I'm converting back to draft since I think there's a better way to accomplish this. |
Closes #3615 * Update the @sentry/browser client to not send durations when capturing sessions. * Leverage timestampInSeconds from @sentry/utils instead of Date.now() to make sure that durations are correctly reported to Sentry.
Previously in c9b3d10, the duration was updated to be undefined when the browser SDK sent sessions to Sentry. This patch removes that logic and instead adds a browser flag to the Session class, which indicates if a duration should be included or not.
AbhiPrasad
force-pushed
the
abhi/session-duration-fix
branch
3 times, most recently
from
97d9395 to
2fbd61e
Compare
AbhiPrasad
force-pushed
the
abhi/session-duration-fix
branch
from
2fbd61e to
a4857c9
Compare
rhcarvalho
reviewed
May 31, 2021
rhcarvalho
reviewed
May 31, 2021
rhcarvalho
approved these changes
Jun 1, 2021
Contributor
rhcarvalho
left a comment
rhcarvalho
left a comment
There was a problem hiding this comment.
I think this should indeed fix the problems we found. Thanks @AbhiPrasad.
A few optional suggestions.
AbhiPrasad
force-pushed
the
abhi/session-duration-fix
branch
from
0619ed2 to
96da8f5
Compare
* ref: Switch from isBrowser -> ignoreDuration * test: Add sanity check test for sec to ms conversion * ref: Update session.close tests to assert on session instead of spying on implementation
AbhiPrasad
force-pushed
the
abhi/session-duration-fix
branch
from
96da8f5 to
9ba5968
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3615
Update the @sentry/hub session to not send durations in browser env. A
flag is used to indicate if a session is in a browser environment.
Leverage timestampInSeconds from @sentry/utils instead of Date.now()
to make sure that durations are correctly reported to Sentry.
Before submitting a pull request, please take a look at our
Contributing guidelines and verify:
yarn lint) & (yarn test).