fix(nextjs): Fix duplicated extension when compiling sentry.server.config.js
#3597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
kmclb-nextjs-fix-merging-webpack-config
to
kmclb-next-js-performance
May 25, 2021 15:50
AbhiPrasad
requested changes
May 25, 2021
Contributor
size-limit report
|
AbhiPrasad
approved these changes
May 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The files being output by webpack after it compiles
sentry.server.config.jsare currently coming out with a double extension (.js.js), because we include the.jseven though webpack also adds one. This fixes that by removing our.jswhen passing the file to webpack. (The.jscan't just be removed from the constant because it's needed elsewhere).