@sentry/nextjs Fix NextConfigExports compatibility #3592
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing type `import('next/dist/next-server/server/config').NextConfig` into `withSentryConfig` results in a type-checking error (`ts(2345)`):
```
Argument of type 'NextConfig' is not assignable to parameter of type 'NextConfigExports'.
Types of property 'experimental' are incompatible.
Type '{ cpus?: number; plugins?: boolean; profiling?: boolean; sprFlushToDisk?: boolean; reactMode?: "legacy" | "concurrent" | "blocking"; workerThreads?: boolean; pageEnv?: boolean; optimizeImages?: boolean; ... 13 more ...; gzipSize?: boolean; }' is not assignable to type '{ plugins: boolean; }'.
Property 'plugins' is optional in type '{ cpus?: number; plugins?: boolean; profiling?: boolean; sprFlushToDisk?: boolean; reactMode?: "legacy" | "concurrent" | "blocking"; workerThreads?: boolean; pageEnv?: boolean; optimizeImages?: boolean; ... 13 more ...; gzipSize?: boolean; }' but required in type '{ plugins: boolean; }'.
```
meeq
commented
May 24, 2021
| import { logger } from '@sentry/utils'; | ||
| import defaultWebpackPlugin, { SentryCliPluginOptions } from '@sentry/webpack-plugin'; | ||
| import * as SentryWebpackPlugin from '@sentry/webpack-plugin'; | ||
| import { NextConfig } from 'next/dist/next-server/server/config'; |
Contributor
Author
There was a problem hiding this comment.
iker-barriocanal
approved these changes
Jun 10, 2021
Contributor
|
Resolved conflicts and merged manually via 888c14a |
auto-merge was automatically disabled
June 10, 2021 09:57
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing type
import('next/dist/next-server/server/config').NextConfigintowithSentryConfigresults in a type-checking error (ts(2345)):